htmlagilitypack Source Control Rss Feed

Patch Uploaded: #14118

Dzonny — Mon, 18 Mar 2013 18:04:24 GMT

Dzonny has uploaded a patch.

Description:
This patch fixes various issues related to XPath and XSLT.
* Infinite loops and stack overflows when applying XSL transformation
* Wrong implementation of some stuff in HtmlNodeNavigator related to attributes (parnt node of attribute, leaving attributes, not taking into account or not reseting _attindex on various places, nonconformance with XPathNavigator documentation for some methods or properties)
* Impossible to select attributes or combined attributes+nodes via XPath on HtmlNode
* Generally missing support for attributes in HtmlNodeCollection
* Created new HtmlCollection type which becomes parent of HtmlNodeCollection. Implementation of methods split between HtmlCollection and HtmlNodeCollection as appropriate
* Created common inferface for HtmlNode and HtmlAttribute - IHtmlNode

* Includes
** patch#14064 (Fix to NullReferenceException in getter of HtmlAttribute.Value)
** Solution to [discussion:435708] (Make HtmlNode.WriteTo virtual)

Patch Uploaded: #14064

Dzonny — Tue, 12 Mar 2013 15:43:04 GMT

Dzonny has uploaded a patch.

Description:
Fix to NullReferenceException in getter of HtmlAttribute.Value

I'm not sure if any additional check is good. I'm just checking _ownerdocument.Text for null. and returning null if it is null.

Patch Uploaded: #14038

sjdirect — Fri, 08 Mar 2013 21:27:05 GMT

sjdirect has uploaded a patch.

Description:
Attached two html pages that when .LoadHtml(thePageContent) is called will cause a stackoverflowexception. THIS IS NOT A PATCH but just more info the patch i just submitted. Also in the previous patch i did not add the related issues. I did so on this one...

#30268 - StackOverflowException loading large document. (x)
#30837 - StackOverflowException

Patch Uploaded: #14035

sjdirect — Fri, 08 Mar 2013 20:40:57 GMT

sjdirect has uploaded a patch.

Description:
Problem:
HtmlAgilityPack throws stackoverflow exception when attempting to load html with tons of nested nodes. Attached two html files that make it easily reproducable. Loadhtml(string) will cause a stack overflow if you read in the content of either of the files.

Solution:
Patched html agility to fix this issue. Added HtmlDocument.OptionMaxNestedChildNodes that can be set to prevent StackOverflowExceptions that are caused by tons of nested tags. It will throw an ApplicationException with message "Document has more than X nested tags. This is likely due to the page not closing tags properly."

How I'm Using After Patch...
HtmlDocument hapDoc = new HtmlDocument();
hapDoc.OptionMaxNestedChildNodes = 5000;
string rawContent = GETTHECONTENTHERE
try
{
hapDoc.LoadHtml(RawContent);
}
catch (Exception e)
{
hapDoc.LoadHtml("");
_logger.Error(e);
}
Also explained here... https://code.google.com/p/abot/issues/detail?id=77

Attached Zip Contents:
HtmlAgilityPack.dll: This is the resulting patched binary
FullProject/htmlagilitypack-99964_Original: Original src i got from the site
FullProject/htmlagilitypack-99964_Modified: The src with patch included
AlteredIndividualFiles/HtmlDocument.cs: Added OptionMaxNestedChildNodes
AlteredIndividualFiles/HtmlNode.cs: Added Depth and SetParent() that tracks node depth
AlteredIndividualFiles/HtmlNodeCollection.cs: Replaced calls node.SetParent(_parentnode) instead of node._parentnode = _parentnode;
AlteredIndividualFiles/HtmlNodeTest.cs: Added a few unit tests

Patch Uploaded: #13919

IDisposable — Thu, 21 Feb 2013 23:59:56 GMT

IDisposable has uploaded a patch.

Description:
Fixes StackOverflow issues on large documents like:

http://dev.w3.org/html5/html-author/charref

Used code patch from luqasn
http://htmlagilitypack.codeplex.com/workitem/30268

Tested against current trunk version.

Patch Uploaded: #13652

zuken21 — Wed, 16 Jan 2013 03:20:07 GMT

zuken21 has uploaded a patch.

Description:
Problem:
HtmlEntity failed to deentity text like that: "eating & sleeping;"

It's because a direct get value in dictionary in HtmlEntity.cs without checking if named entity is exist or not:
object o = _entityValue[entity.ToString()];
...

Solution:
Perform checking before get

// named entity?
int code;
if (_entityValue.TryGetValue(entity.ToString(), out code))
{
// we found one
sb.Append(Convert.ToChar(code));
}
else
{
// nope
sb.Append("&" + entity + ";");
}

Patch Uploaded: #13568

sugiantow70 — Tue, 01 Jan 2013 12:28:49 GMT

sugiantow70 has uploaded a patch.

Description:
no show

Source code checked in, #99964

DarthObiwan — Wed, 10 Oct 2012 01:11:47 GMT

Updated HAPPhone.7.1 project to include needed SL 4 libraries for nuget package

Source code checked in, #99963

DarthObiwan — Wed, 10 Oct 2012 01:01:54 GMT

Updated nuget directory for WinRT apps to new NetCore45 needed by nuget Updated nuget spec doc to 1.4.7

Source code checked in, #99962

DarthObiwan — Wed, 10 Oct 2012 00:11:11 GMT

Updates for workitem #25278 Changed WriteAttribute to honor OptionOutputOriginalCase=true Added unit test to test this functionality Updated AssemblyInfo.cs to allow internals to be visible to the HAP Unit Tests project

Patch Uploaded: #12967

rburte — Tue, 02 Oct 2012 22:42:41 GMT

rburte has uploaded a patch.

Description:
Adds test to honor OptionOutputOriginalCase flag when writing out attributes in an HTML file (case is already covered in an file output as XML).
This is critical for me to preserve case in an embedded XML data island.
This patch is against the current main branch release (changeset 98677: HTMLAgilityPack/HtmlNode.cs)

Supercedes patch 12834 - which was based off another branch.

Source code checked in, #99885

Project Collection Service Accounts — Mon, 01 Oct 2012 21:24:31 GMT

Upgrade: New Version of LabDefaultTemplate.xaml. To upgrade your build definitions, please visit the following link: http://go.microsoft.com/fwlink/?LinkId=254563

Source code checked in, #99884

Project Collection Service Accounts — Mon, 01 Oct 2012 21:16:08 GMT

Checked in by server upgrade

Source code checked in, #99803

simonm — Mon, 24 Sep 2012 09:00:58 GMT

Fix for issues #31858, #32952, #32959 and #32961 (Inner and Outer Html cache is not cleared properly)

Patch Uploaded: #12834

rburte — Thu, 06 Sep 2012 21:30:02 GMT

rburte has uploaded a patch.

Description:
Honor the OptionOutputOriginalCase flag when writing out attributes (as opposed to tag names).

Patch Uploaded: #12804

dimazhiyanov — Fri, 31 Aug 2012 01:30:15 GMT

dimazhiyanov has uploaded a patch.

Description:
To prevent stack overflow in HTML documents with a large number of unclosed tags, limit the depth of the node.

Attaching HtmlNode.cs file. Sorry I am new to codeplex

Make HtmlNode._parentNode private instead of internal and introduce

internal void SetParentNode(HtmlNode parentNode)
{
if (parentNode == null)
{
this._parentnode = null;
this._depth = 0;
}
else
{
if (parentNode._depth >= _maxNodeDepth)
{
throw new ArgumentException(String.Format("Maximum node depth reached: {0}", _maxNodeDepth));
}

this._parentnode = parentNode;
this._depth = parentNode._depth + 1;
}
}

Source code checked in, #99300

DarthObiwan — Thu, 23 Aug 2012 14:26:48 GMT

Issue #30608: Added returning the immediate parent when calling ancestors Added readme for the solutions files

Source code checked in, #99275

DarthObiwan — Mon, 20 Aug 2012 19:25:27 GMT

Experimental 2.0: Removed references to .snk file and HtmlBaseNode.cs. Added reference to IHtmlBaseNode.cs

Source code checked in, #99183

DarthObiwan — Mon, 13 Aug 2012 23:39:50 GMT

Code for Nuget reference test projects

Source code checked in, #99182

DarthObiwan — Mon, 13 Aug 2012 23:36:49 GMT

Adding nuget reference testing project files